Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Skelett60 #23409

Merged
merged 8 commits into from
Apr 6, 2024
Merged

[Keyboard] Add Skelett60 #23409

merged 8 commits into from
Apr 6, 2024

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Apr 3, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 3, 2024
@fauxpark fauxpark requested a review from a team April 3, 2024 13:04
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add compatible Community Layouts support
  • for keymap.c, replace KC_TRNS with _______ for human readability

keyboards/novelkeys/skelett60/info.json Outdated Show resolved Hide resolved
keyboards/novelkeys/skelett60/info.json Show resolved Hide resolved
keyboards/novelkeys/skelett60/info.json Show resolved Hide resolved
keyboards/novelkeys/skelett60/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/novelkeys/skelett60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An image of this PCB would be helpful 🙂

Comment on lines +23 to +36
### Reset

- Unplug
- Hold Escape
- Plug In
- Unplug
- Release Escape

### Flash

- Unplug
- Hold Escape
- Plug In
- Flash using QMK Toolbox or CLI (`make novelkeys/skelett60:<keymap>:flash`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text adheres more closely to the template. Is there a physical reset button?

Suggested change
### Reset
- Unplug
- Hold Escape
- Plug In
- Unplug
- Release Escape
### Flash
- Unplug
- Hold Escape
- Plug In
- Flash using QMK Toolbox or CLI (`make novelkeys/skelett60:<keymap>:flash`)
## Bootloader
Enter the bootloader in 3 ways:
* **Bootmagic reset**: Hold down the top left key (normally Escape) and plug in the keyboard. This will also clear emulated EEPROM, so it is a good first step if the keyboard is misbehaving.
* **Physical reset button**:
* **Keycode in layout**: There is no key mapped to `QK_BOOT` in the pre-created keymaps, but you may assign this key in any keymaps you create.
## Flashing
After entering the bootloader through one of the methods above, the keyboard can be flashed using the QMK CLI (see "Flashing example") or QMK Toolbox.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Physical button but I do not recommend it as it doesnt clear the eeprom. I think my description is more straight forward. I can change to the suggestion if the majority thinks so.

@@ -0,0 +1,36 @@
# Skelett 60

This is a standard 60% layout PCB. It supports VIA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is a standard 60% layout PCB. It supports VIA.
This is a standard 60% layout PCB.

(The default keymap doesn't.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No default keymap does. Its the "tradition"

@keyboard-magpie keyboard-magpie merged commit 36ae585 into qmk:master Apr 6, 2024
3 checks passed
@yiancar yiancar mentioned this pull request Apr 17, 2024
7 tasks
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
Co-authored-by: yiancar <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
IvanJackson pushed a commit to IvanJackson/qmk_firmware that referenced this pull request May 6, 2024
Co-authored-by: yiancar <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
Co-authored-by: yiancar <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Co-authored-by: yiancar <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants